ADFA-4958: show install size in the action sheet; maps/matomo size labels - #316
Merged
Merged
Conversation
…§5.3) The module action sheet header subtitle was "project · state"; the handoff §5.3 asks for "project · state · size". Append "≈ <size>" from the existing ModuleSizes/ByteFormatter (same source as the detail chip); omitted when the size is unknown (matomo/maps). Wording/format only, no behavior change.
maps has no single install size — its footprint depends on the layers/levels the user selects and grows steeply. Instead of "NA", show a curated floor "200 MB+" (ModuleCards.sizeLabelRes) in both the detail size chip and the action-sheet subtitle. The "+" conveys the floor, so the chip drops the "≈" prefix for maps. Measured modules are unchanged.
- matomo gets a curated size "≈ 114 MB" (from a manual install measurement; incl. MariaDB + the Matomo tarball). Now every module shows a size: kolibri/calibreweb/ kiwix/code measured, maps "200 MB+", matomo "≈ 114 MB". - matomo is a demo/example module (runs, but not a real production feature): the detail shows a "Demo" chip (ModuleCards.isDemo). Label only, no behavior change.
…isible) The size/version chips (and the HIDDEN → Restore pill) used k2go_chip_bg, a solid teal fill, with teal text on top — so the text was invisible (empty teal pills). That drawable is the "selected" filled pill used elsewhere, so leave it as is and make these render as outlined pills instead (transparent fill, colored stroke + text), per the handoff (§5.4 chips, §5.7 Restore). Runs offline / Demo were already legible; now size, version and Restore are too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to ADFA-4958 (merged). Rounds out the module-size story: every module now shows a size, and the action sheet carries it.
What changed
Result: kolibri / calibreweb / kiwix / code keep their measured "≈ …"; maps "200 MB+"; matomo "≈ 114 MB".
Scope: labels/format only — no routing or behavior change. UI verifiable in dark and light on the module detail and the action sheet.